[FLINK-27675] Improve manual savepoint tracking #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am doing a manual verification in my minikube. |
| return Optional.of(errorMsg); | ||
| } else { | ||
| LOG.info("Savepoint operation not running yet, waiting within grace period..."); |
There was a problem hiding this comment.
not running yet -> not finished yet? The savepoint should already be triggered successfully.
thanks! |
| @@ -98,6 +98,10 @@ public void observe(FlinkDeployment flinkApp, Context context) { | |||
| } | |||
| } | |||
|
|
|||
| if (!ReconciliationUtils.isJobRunning(flinkApp.getStatus())) { | |||
There was a problem hiding this comment.
We might also need to create an event when we canceling the savepoint operation. At least, we need to add a log when doing a concrete reset(when the triggerId is not empty).
There was a problem hiding this comment.
Works well after manual verification. After this PR, the savepoint failure now is more easily to be found.
Events:
Type Reason Age From Message
---- ------ ---- ---- -------
Warning SavepointError 33m Operator Savepoint failed for savepointTriggerNonce: 2
Warning SavepointError 17m Operator Savepoint failed for savepointTriggerNonce: 3
The savepoint process still could be improved in FLINK-27257 by supporting retrying at some given exception.
|
Will merge this PR after CI pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancelling savepoint operation on application failures
Cancelling savepoint operation on savepoint fetching failures
Generating events for failed savepoint operations