[FLINK-27804] Do not observe cluster/job mid upgrade #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this PR could work when the operator failed before patching the status, but after the job is canceled with savepoint successfully? |
|
Yes @wangyang0918 as it would only be in UPGRADING state if patching succeeded after the cancel-with-savepoint operation |
When the JobManager pod exactly failed over at the same time, we will never get the savepoint. But this is out the scope of this PR. |
|
Merging this for now, there is definitely follow up work to be done in the future to handle cases when the actual deployment step fails during an upgrade which is generally not handled at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPGRADING state means we have either deleted the deployment for last-state upgrades or observed the result of the cancel with savepoint operation.
No need to further observe anything