Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-31857] Observer plugin #570

Closed
wants to merge 2 commits into from
Closed

Conversation

darenwkt
Copy link
Contributor

What is the purpose of the change

Support pluginable Observer to allow user to load a plugin JAR to run custom observer logic.

Brief change log

  • Added FlinkResourceObserverPlugin interface for users to implement in plugin JAR with custom observer logic.

Verifying this change

  • Added unit test to verify TestObserverPlugin is discoverable.
  • Manual test by loading a sample JAR that changes the jobName in FlinkSessionJob status field and verified successfully.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changes to the CustomResourceDescriptors: ( no)
  • Core observer or reconciler logic that is regularly executed: (yes)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@darenwkt darenwkt changed the title Observer plugin [FLINK-31857] Observer plugin Apr 19, 2023
@gyfora
Copy link
Contributor

gyfora commented Apr 20, 2023

I think we should design this together with the reconciler plugin and there should be a FLIP for it to make sure that other users can influence the design and we cover existing features like the autoscaler etc with the pluggable mechanism.

@darenwkt darenwkt closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants