Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-27715] Add pyflink examples #121

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[FLINK-27715] Add pyflink examples #121

merged 1 commit into from
Jun 29, 2022

Conversation

yunfengzhou-hub
Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub commented Jun 27, 2022 •
edited

This PR is a continuation of #115 . It adds pyflink examples for Flink ML's algorithms.

This PR also does the following:

  • fixes an exception message in IndexToStringModel.java
  • fixes a bug in linalg.py
  • deduplicates test cases in test_logisticregression.py
  • fixes comments and API in stringindexer.py
  • adds test cases for IndexToStringModel
  • adds python support for Linear Regression algorithm

@yunfengzhou-hub yunfengzhou-hub changed the title [FLINK-28237] Add pyflink examples [FLINK-27715] Add pyflink examples Jun 27, 2022
@yunfengzhou-hub yunfengzhou-hub force-pushed the FLINK-28237 branch 7 times, most recently from 66dfd1c to 0951463 Compare June 28, 2022 09:02
lindong28
lindong28 reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM overall. Left one comment below.

flink-ml-python/pyflink/examples/ml/__init__.py Outdated Show resolved Hide resolved
@yunfengzhou-hub yunfengzhou-hub force-pushed the FLINK-28237 branch 3 times, most recently from d2ce306 to f8fb01a Compare June 29, 2022 02:09
@lindong28
Copy link
Member

Thanks for the update. LGTM.

@lindong28 lindong28 merged commit 91e7464 into apache:master Jun 29, 2022
lindong28 pushed a commit to lindong28/flink-ml that referenced this pull request Jun 30, 2022
@yunfengzhou-hub @lindong28
Add pyflink examples
bade343 
This closes apache#121.
@lindong28 lindong28 mentioned this pull request Jun 30, 2022
Merged
@yunfengzhou-hub yunfengzhou-hub mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 lindong28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yunfengzhou-hub @lindong28