-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-24655][iteration] Support the checkpoints for the iteration #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2021
flink-ml-iteration/src/main/java/org/apache/flink/ml/iteration/operator/HeadOperator.java
Outdated
Show resolved
Hide resolved
...ration/src/main/java/org/apache/flink/ml/iteration/datacache/nonkeyed/DataCacheSnapshot.java
Outdated
Show resolved
Hide resolved
...k-ml-iteration/src/main/java/org/apache/flink/ml/iteration/checkpoint/CheckpointsBroker.java
Outdated
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/ml/iteration/operator/HeadOperator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/ml/iteration/operator/coordinator/HeadOperatorCoordinator.java
Outdated
Show resolved
Hide resolved
...org/apache/flink/ml/iteration/operator/headprocessor/RegularHeadOperatorRecordProcessor.java
Outdated
Show resolved
Hide resolved
gaoyunhaii
force-pushed
the
i10_add_checkpoints
branch
2 times, most recently
from
October 25, 2021 15:59
ea8599d
to
cb50626
Compare
guoweiM
reviewed
Nov 1, 2021
...ion/src/main/java/org/apache/flink/iteration/operator/coordinator/SharedProgressAligner.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/apache/flink/iteration/operator/coordinator/SharedProgressAligner.java
Show resolved
Hide resolved
...ion/src/main/java/org/apache/flink/iteration/operator/coordinator/SharedProgressAligner.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/org/apache/flink/iteration/operator/coordinator/SharedProgressAligner.java
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/HeadOperator.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
...eration/src/main/java/org/apache/flink/iteration/operator/HeadOperatorCheckpointAligner.java
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
...n/src/main/java/org/apache/flink/iteration/operator/coordinator/HeadOperatorCoordinator.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/flink/iteration/operator/coordinator/HeadOperatorCoordinator.java
Outdated
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/HeadOperator.java
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
...teration/src/test/java/org/apache/flink/iteration/itcases/BoundedAllRoundCheckpointTest.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
flink-ml-iteration/src/test/java/org/apache/flink/iteration/itcases/operators/FailingMap.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
flink-ml-iteration/src/test/java/org/apache/flink/iteration/itcases/operators/FailingMap.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
...rc/test/java/org/apache/flink/iteration/itcases/operators/ReduceAllRoundProcessFunction.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/InputOperator.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
.../main/java/org/apache/flink/iteration/operator/allround/AbstractAllRoundWrapperOperator.java
Outdated
Show resolved
Hide resolved
guoweiM
reviewed
Nov 1, 2021
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/ReplayOperator.java
Show resolved
Hide resolved
gaoyunhaii
force-pushed
the
i10_add_checkpoints
branch
from
November 2, 2021 08:17
cb50626
to
1df3491
Compare
gaoyunhaii
changed the title
[FLINK-10][iteration] Support the checkpoints for the iteration.
[FLINK-24655][iteration] Support the checkpoints for the iteration
Nov 3, 2021
…s back before terminating. This is a basis for the checkpoint since for checkpoints with feedback edges, we would need to also include the feedback records into snapshot, thus if we want to make sure all the checkpoints before the terminated globally aligned events get done, we have to wait for one more round.
…for each checkpoint
… epoch watermark If the finished and failover, then it would be skipped and would not insert the epoch watermark again.
gaoyunhaii
force-pushed
the
i10_add_checkpoints
branch
from
November 3, 2021 11:56
1df3491
to
e6c1001
Compare
guoweiM
approved these changes
Nov 3, 2021
Very thank @yunfengzhou-hub and @guoweiM for the review! will merge~ |
zhipeng93
pushed a commit
to zhipeng93/flink-ml
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the checkpoint mechanism for the iteration. The target of the checkpoint mechanism is to ensure
The checkpoints relies on the reference count mechanism to include the feedback records into snapshots. Besides, it also take cares of the state for the controller operator / all-round wrappers and per-round wrappers. At this version it introduce some limitation in that it does not allows for the all the operators inside the iteration to change parallelism after restart from checkpoint. For the long run, the condition could be relaxed to