Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-29911] Improve performance of AgglomerativeClustering #171

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[FLINK-29911] Improve performance of AgglomerativeClustering #171

merged 1 commit into from
Dec 13, 2022

Conversation

zhipeng93
Copy link
Contributor

@zhipeng93 zhipeng93 commented Nov 6, 2022 •
edited

What is the purpose of the change

This PR aims to improve the performance of AgglomerativeClustering.

Brief change log

  • Improves the performance of AgglomerativeClustering by more than 10x, following "Modern hierarchical, agglomerative clustering algorithms", by Daniel Mullner. For example given 4K input data points, the old implementation needs ~120s, while this PR needs ~10s.
  • Fixed on corner case when using linkage as ward and distance as euclidean.
  • Fixed some typos in UT.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhipeng93 zhipeng93 marked this pull request as draft November 7, 2022 02:37
@zhipeng93 zhipeng93 marked this pull request as ready for review November 7, 2022 06:06
yunfengzhou-hub
yunfengzhou-hub reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@yunfengzhou-hub yunfengzhou-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments as below.

flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/AgglomerativeClusteringTest.java Show resolved Hide resolved
...ain/java/org/apache/flink/ml/clustering/agglomerativeclustering/AgglomerativeClustering.java Outdated Show resolved Hide resolved
...ain/java/org/apache/flink/ml/clustering/agglomerativeclustering/AgglomerativeClustering.java Outdated Show resolved Hide resolved
@zhipeng93 zhipeng93 force-pushed the nn_clustering branch 2 times, most recently from 59fb19d to 843f101 Compare December 1, 2022 02:38
@yunfengzhou-hub
Copy link
Contributor

Thanks for the update! It LGTM.

@lindong28
Copy link
Member

Thanks for the PR! LGTM.

@lindong28 lindong28 merged commit 7360966 into apache:master Dec 13, 2022
Fanoid pushed a commit to Fanoid/flink-ml that referenced this pull request Apr 6, 2023
@zhipeng93
[FLINK-29911] Improve performance of AgglomerativeClustering
9a647b0 
This closes apache#171.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunfengzhou-hub yunfengzhou-hub yunfengzhou-hub left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zhipeng93 @yunfengzhou-hub @lindong28