[FLINK-29602] Add Transformer for SQLTransformer #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
from
9f30087
to
460a287
Compare
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
from
460a287
to
5be436f
Compare
jiangxin369
reviewed
Nov 16, 2022
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/sqltransformer/SQLTransformer.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/sqltransformer/SQLTransformerParams.java
Show resolved
Hide resolved
flink-ml-python/pyflink/ml/lib/feature/tests/test_sqltransformer.py
Outdated
Show resolved
Hide resolved
|
Thanks for the update. LGTM overall. @lindong28 Could you please take a look at this PR? |
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
from
7909309
to
8a9b61d
Compare
lindong28
reviewed
Nov 17, 2022
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/SQLTransformerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/SQLTransformerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/SQLTransformerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/sqltransformer/SQLTransformer.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
5 times, most recently
from
11a38a5
to
d0082be
Compare
lindong28
reviewed
Nov 18, 2022
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/sqltransformer/SQLTransformer.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/SQLTransformerTest.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
from
d0082be
to
7ef8ab8
Compare
yunfengzhou-hub
force-pushed
the
FLINK-29602
branch
from
7ef8ab8
to
c321392
Compare
|
Thanks for the update! LGTM. |
Fanoid
pushed a commit
to Fanoid/flink-ml
that referenced
this pull request
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds the Transformer for the SQL transformer algorithm.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation