[FLINK-30249] Fix TableUtils.getRowTypeInfo by using ExternalTypeInfo.of() #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhipeng93
force-pushed
the
FLINK-30249
branch
from
350f601
to
907b784
Compare
zhipeng93
changed the title
zhipeng93
force-pushed
the
FLINK-30249
branch
4 times, most recently
from
4005206
to
81cacf8
Compare
|
Can you help to review this PR @gaoyunhaii @lindong28? |
zhipeng93
force-pushed
the
FLINK-30249
branch
from
81cacf8
to
2e6876b
Compare
flink-ml-core/src/test/java/org/apache/flink/ml/common/datastream/TableUtilsTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/binarizer/Binarizer.java
Show resolved
Hide resolved
zhipeng93
force-pushed
the
FLINK-30249
branch
2 times, most recently
from
34fce80
to
6503e73
Compare
lindong28
reviewed
Jan 4, 2023
flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/TableUtils.java
Outdated
Show resolved
Hide resolved
|
Thanks for the update! LGTM. |
vacaly
pushed a commit
to vacaly/flink-ml
that referenced
this pull request
Feb 8, 2023
….of() This closes apache#188.
vacaly
pushed a commit
to vacaly/flink-ml
that referenced
this pull request
Feb 10, 2023
….of() This closes apache#188.
Fanoid
pushed a commit
to Fanoid/flink-ml
that referenced
this pull request
Apr 6, 2023
….of() This closes apache#188.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix
TableUtils.getRowTypeInfo()by avoiding usingTypeInformation.of(...).Currently TypeInformation created
TypeInformation.of()may not be correctly identified when converting between tables and datastreams. (e.g., TimeStamp, CHAR, Decimal in the added test case)Brief change log
TableUtils.getRowTypeInfo()by usingExternalTypeInfo.of()and added corresponding unit test.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation