[FLINK-24807][iteration] Fix the issues in checkpoints with iteration #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoyunhaii
force-pushed
the
i10_add_checkpoints_per_round
branch
from
f14e74c
to
29ce569
Compare
guoweiM
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Thanks @gaoyunhaii for opening this pr. I have some following minor comments below.
BTW I just think that we could not support Batch execution mode. So I think it would be nice to tell the user when they set the execution mode to Batch. I am sorry that I find it so late. But I think you could open a separate pr for this.
Thanks
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/ReplayOperator.java
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/ReplayOperator.java
Outdated
Show resolved
Hide resolved
flink-ml-iteration/src/test/java/org/apache/flink/iteration/operator/ReplayOperatorTest.java
Show resolved
Hide resolved
flink-ml-iteration/src/test/java/org/apache/flink/iteration/operator/ReplayOperatorTest.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/flink/iteration/operator/perround/AbstractPerRoundWrapperOperator.java
Show resolved
Hide resolved
.../main/java/org/apache/flink/iteration/operator/perround/AbstractPerRoundWrapperOperator.java
Show resolved
Hide resolved
.../main/java/org/apache/flink/iteration/operator/perround/AbstractPerRoundWrapperOperator.java
Show resolved
Hide resolved
...-ml-tests/src/test/java/org/apache/flink/test/iteration/BoundedPerRoundCheckpointITCase.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/flink/test/iteration/operators/TwoInputReducePerRoundOperator.java
Outdated
Show resolved
Hide resolved
…rminating Currently the HeadCoordinator would emit CoordinatorCheckpointEvent to the tasks so that the GloballyAlignedEvent would not be interleave with the checkpoint barrier. Howver, if the tasks are finished and we continue emitting the event, the checkpoint would fail due to there are failed operator events. To address this issue, we would stop emitting CoordinatorCheckpointEvent after the head operator is terminating, namely it received the GloballyAlignedEvent marking terminating.
…e barrier feed back first
gaoyunhaii
force-pushed
the
i10_add_checkpoints_per_round
branch
from
29ce569
to
00ec475
Compare
guoweiM
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have met some more issues in supporting checkpoints with iteration:
Specially for the second point, Currently the HeadCoordinator would emit CoordinatorCheckpointEvent to the tasks so that the GloballyAlignedEvent would not be interleave with the checkpoint barrier. However, if the tasks are finished and we continue emitting the event, the checkpoint would fail due to there are failed operator events. To address this issue, we would stop emitting CoordinatorCheckpointEvent after the head operator is terminating, namely it received the GloballyAlignedEvent marking terminating.
The third point is required since operators like
withBroadcastmight rely on raw operator state to snapshot the cached records. This is necessary since the normal operator state always resides in the memory, which might be not enough.