[FLINK-24810] Add Estimator and Model for the k-means clustering algorithm #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindong28
force-pushed
the
FLINK-24810
branch
6 times, most recently
from
8d514ea
to
deffa84
Compare
lindong28
force-pushed
the
FLINK-24810
branch
7 times, most recently
from
ab0d74a
to
43a54e6
Compare
|
@gaoyunhaii Could you review this PR? |
lindong28
force-pushed
the
FLINK-24810
branch
2 times, most recently
from
fc1dd58
to
572eaf5
Compare
gaoyunhaii
reviewed
Nov 16, 2021
flink-ml-api/src/main/java/org/apache/flink/ml/distance/DistanceMeasure.java
Show resolved
Hide resolved
flink-ml-api/src/main/java/org/apache/flink/ml/linalg/Vectors.java
Outdated
Show resolved
Hide resolved
flink-ml-api/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseVectorSerializer.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/param/HasPredictionCol.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/param/HasFeaturesCol.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/common/datastream/MapPartitionFunctionWrapper.java
Outdated
Show resolved
Hide resolved
gaoyunhaii
reviewed
Nov 16, 2021
...-ml-lib/src/main/java/org/apache/flink/ml/common/datastream/MapPartitionFunctionWrapper.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/clustering/kmeans/KMeansModel.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/param/HasFeaturesCol.java
Outdated
Show resolved
Hide resolved
lindong28
force-pushed
the
FLINK-24810
branch
from
572eaf5
to
50d440a
Compare
lindong28
force-pushed
the
FLINK-24810
branch
from
50d440a
to
c1ebf28
Compare
|
Thanks for your review @gaoyunhaii @yunfengzhou-hub! All comments have been addressed. |
gaoyunhaii
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Very thanks @lindong28 for opening the PR! Will merge after the test get green~
| public KMeansModel fit(Table... inputs) { | ||
| StreamTableEnvironment tEnv = | ||
| (StreamTableEnvironment) ((TableImpl) inputs[0]).getTableEnvironment(); | ||
| DataStream<DenseVector> points = |
There was a problem hiding this comment.
Maybe DataStream<Vector> is enough here?
There was a problem hiding this comment.
Simply making this change will break compilation. Maybe we can make this work by also changing many other places. But I am not sure it is useful to make this change given that we don't support SparseVector yet.
Maybe we can make this change after SparseVector is supported. Then we can write unit tests to validate that KMeans (as well as other algorithms) can support both SparseVector and DenseVector as inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds the Estimator and Model classes for the KMeans algorithm.
Brief change log
This PR mades the following changes:
KMeans,KMeansModeland a few other supporting classes.KMeansTestto validate the behavior ofKMeansandKMeansModel.Verifying this change
The changes are validated by unit tests in the
KMeansTest.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation