[FLINK-24817] Add Estimator and Transformer for Naive Bayes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhipeng93
reviewed
Nov 12, 2021
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/common/datastream/EndOfStreamWindows.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
lindong28
reviewed
Nov 16, 2021
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesParams.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
from
f45c219
to
17a8659
Compare
lindong28
reviewed
Nov 17, 2021
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasLabelCol.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/common/param/HasFeatureSize.java
Outdated
Show resolved
Hide resolved
...l-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelParams.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
from
17a8659
to
f9898b9
Compare
lindong28
reviewed
Nov 18, 2021
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
from
f9898b9
to
87fecca
Compare
lindong28
reviewed
Nov 24, 2021
There was a problem hiding this comment.
Thanks for the update @yunfengzhou-hub. I left some minor comments regarding the code readability.
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/KMeansTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/KMeansTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/KMeansTest.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/clustering/KMeansTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/util/StageTestUtils.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
2 times, most recently
from
27b59b0
to
fdd2729
Compare
zhipeng93
reviewed
Nov 24, 2021
flink-ml-api/src/main/java/org/apache/flink/ml/linalg/BLAS.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
2 times, most recently
from
f378fc2
to
a2fa962
Compare
lindong28
reviewed
Nov 25, 2021
There was a problem hiding this comment.
Thanks for the update @yunfengzhou-hub. Left only some minor comments below.
flink-ml-api/src/main/java/org/apache/flink/ml/linalg/BLAS.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/util/StageTestUtils.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/util/StageTestUtils.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/classification/NaiveBayesTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
from
a2fa962
to
aabb2e3
Compare
|
Thanks for the update! LGTM. @gaoyunhaii could you help review this PR? |
yunfengzhou-hub
force-pushed
the
bayes
branch
2 times, most recently
from
a550979
to
de2563b
Compare
zhipeng93
reviewed
Nov 29, 2021
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
from
de2563b
to
de88a30
Compare
zhipeng93
reviewed
Dec 6, 2021
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModel.java
Outdated
Show resolved
Hide resolved
gaoyunhaii
reviewed
Dec 6, 2021
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayes.java
Outdated
Show resolved
Hide resolved
flink-ml-core/src/main/java/org/apache/flink/ml/linalg/BLAS.java
Outdated
Show resolved
Hide resolved
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Show resolved
Hide resolved
zhipeng93
reviewed
Dec 6, 2021
...-ml-lib/src/main/java/org/apache/flink/ml/classification/naivebayes/NaiveBayesModelData.java
Outdated
Show resolved
Hide resolved
yunfengzhou-hub
force-pushed
the
bayes
branch
2 times, most recently
from
ff097e8
to
901bcd8
Compare
yunfengzhou-hub
changed the title
gaoyunhaii
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Very thanks @yunfengzhou-hub for the updates! LGTM and +1 to merge
yunfengzhou-hub
force-pushed
the
bayes
branch
from
901bcd8
to
40f1bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds the implementation of Naive Bayes algorithm to Flink ML. This algorithm is implemented in reference to that implemented in Alibaba Alink and Apache Spark, but it uses Flink ML's framework and Flink Datastream.
Brief change log
This PR adds public classes NaiveBayes. Users can use NaiveBayes to do training and inference according to the algorithm with the same name. Users can also use MultiStringIndexer to convert strings into indices.
Verifying this change
The changes are tested by unit tests in NaiveBayesTest.
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @public(Evolving): (yes)
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (Java doc)