[hotfix][FLIP-176] Updates onEpochWatermarkIncremented() and onIterationTerminated() to throw Exception #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindong28
force-pushed
the
api-hotfix
branch
from
4dd89dd
to
82a72a8
Compare
zhipeng93
reviewed
Dec 21, 2021
.../src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegression.java
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/iteration/Iterations.java
Outdated
Show resolved
Hide resolved
flink-ml-iteration/src/main/java/org/apache/flink/iteration/Iterations.java
Outdated
Show resolved
Hide resolved
lindong28
changed the title
lindong28
force-pushed
the
api-hotfix
branch
from
82a72a8
to
dfe6cf5
Compare
|
@gaoyunhaii Could you help review this PR? |
…ionTerminated() to throw Exception
lindong28
force-pushed
the
api-hotfix
branch
from
dfe6cf5
to
7b1d5a2
Compare
|
Thanks @lindong28 for opening the PR and @zhipeng93 for the review! I think it would indeed makes users easier and keep consistency with other UDF interfaces~ |
gaoyunhaii
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The purpose of this PR is to simplify the experience of implementing
onEpochWatermarkIncremented()andonIterationTerminated().Brief change log
This PR updated
onEpochWatermarkIncremented()andonIterationTerminated()to throw Exception.Verifying this change
The changes are validated by the existing unit tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation