Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29889][netty] Bundle tcnative-classes #115

Merged
merged 2 commits into from Nov 8, 2022
Merged

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Nov 4, 2022

Nov 03 12:44:46 [INFO] --- maven-shade-plugin:3.1.1:shade (shade-flink) @ flink-shaded-netty-tcnative-static ---
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:2.0.54.Final in the shaded jar.
PROBLEM -> Nov 03 12:44:47 [INFO] Excluding io.netty:netty-tcnative-classes:jar:2.0.54.Final from the shaded jar.
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:linux-x86_64:2.0.54.Final in the shaded jar.
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:linux-aarch_64:2.0.54.Final in the shaded jar.
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:osx-x86_64:2.0.54.Final in the shaded jar.
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:osx-aarch_64:2.0.54.Final in the shaded jar.
Nov 03 12:44:47 [INFO] Including io.netty:netty-tcnative-boringssl-static:jar:windows-x86_64:2.0.54.Final in the shaded jar.

@MartijnVisser
Copy link
Contributor

Looking at

the apache license. https://issues.apache.org/jira/browse/LEGAL-393
, is that mentioned ticket applicable to this PR?

@zentol
Copy link
Contributor Author

zentol commented Nov 8, 2022

is that mentioned ticket applicable to this PR?

Yes. That's why the static module isn't included in the build by default. It's something users have to build themselves.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

@zentol zentol merged commit 3082afc into apache:master Nov 8, 2022
@zentol zentol deleted the 29889 branch November 8, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants