[FLINK-30232][Build/Shaded] Include all platforms incl ARM64 while shading Netty #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
reviewed
Jan 13, 2023
zentol
requested changes
Jan 17, 2023
There was a problem hiding this comment.
This doesn't cover all native files of netty4. There are some macos-specific resolved libraries that also need to be relocated.
If you follow my suggestion these should be automatically covered.
The same streamlining should be applied to the dynamic tcnative module, whereas the static tcnative module is also missing a relocation for macos.
… ARM64) platforms while shading Netty
… ARM64) platforms while shading Netty Tcnative Dynamic
MartijnVisser
force-pushed
the
FLINK-30232
branch
from
d65d4b3
to
589317d
Compare
We can't do that for the dynamic tcnative module, per https://github.com/apache/flink-shaded/blob/master/flink-shaded-netty-tcnative-dynamic/pom.xml#L157 - I've tried to streamline it but then it doesn't work properly. The other comments have been taken care off |
zentol
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.