Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-11022] Rework licensing #52

Merged
merged 3 commits into from Jan 31, 2019
Merged

[FLINK-11022] Rework licensing #52

merged 3 commits into from Jan 31, 2019

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Dec 12, 2018

This PR reworks the licensing in line with FLINK-10987.

@NicoK NicoK mentioned this pull request Jan 9, 2019
Merged
tillrohrmann
tillrohrmann approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I had a single comment concerning sorting of the dependency entries. Apart from that +1 for merging.

flink-shaded-asm-6/src/main/resources/META-INF/NOTICE Outdated

- org.ow2.asm:asm:6.2.1
- org.ow2.asm:asm-tree:6.2.1
- org.ow2.asm:asm-analysis:6.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not alphabetically sorted

@zentol zentol merged commit daa7317 into apache:master Jan 31, 2019
@zentol zentol deleted the 11022 branch February 6, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zentol @tillrohrmann