Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11219] Upgrade Jackson version to 2.9.6 #54

Closed
wants to merge 1 commit into from

Conversation

XuQianJin-Stars
Copy link

@XuQianJin-Stars XuQianJin-Stars commented Dec 26, 2018

Upgrade Jackson version to 2.9.6
Because the Jackson version supported by calcite1.18.0 has been upgraded to Jackson 2.9.6.
Need to upgrade flink jackson in the shaded version
Because many flink dependency from the flink-shaded.

#53

@zentol zentol changed the title Upgrade Jackson version to 2.9.6 [FLINK-11219] Upgrade Jackson version to 2.9.6 Jan 16, 2019
@zentol
Copy link
Contributor

zentol commented Jan 16, 2019

It doesn't make sense to bump jackson to share it with calcite.

This could only work if you can safely relocate jackson usages in calcite in the first place, but that means we don't have to share flink-shaded-jackson. We can just let calcite use it's own own (relocated) version.
You'd just end up with unnecessary coupling between Flink and Calcite along with a more brittle build process (since the shading pattern in flink-table has to match flink-shaded-jackson).

@zentol zentol closed this Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants