Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-23325] Bump netty to 4.1.65 #95

Merged
merged 3 commits into from Jul 9, 2021
Merged

[FLINK-23325] Bump netty to 4.1.65 #95

merged 3 commits into from Jul 9, 2021

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Jul 9, 2021

Our shading setup for native bindings, which need to be bumped to 2.0.39, needed most of the changes.

  • The netty files have been renamed, so I had to adjust our file matching & renaming.
  • the dynamic windows binding appears to no longer exist 馃し
  • there's now a dynamic binding for ARM
  • there's now a dynamic binding specific to Fedora Linux, which needs some special handling because the file name clash with the vanilla Linux one (voidig some of the benefits of renaming things in the first place...)

tillrohrmann
tillrohrmann approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. LGTM modulo one comment. +1 for merging after addressing it.

flink-shaded-netty-4/src/main/resources/META-INF/NOTICE Outdated Show resolved Hide resolved
@zentol @tillrohrmann
Update flink-shaded-netty-4/src/main/resources/META-INF/NOTICE
41ec0a9 
Co-authored-by: Till Rohrmann <till.rohrmann@gmail.com>
@zentol zentol merged commit 0dafc0b into apache:master Jul 9, 2021
@zentol zentol deleted the 23325 branch July 13, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zentol @tillrohrmann