[FLINK-25899] Add connected components example #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalshilman
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Thanks @tillrohrmann! this is a very interesting example, and really shows the versatility of StateFun!
I've left few comments for your consideration, mainly it is about the use of Java serialisation, and Types in general.
.../main/java/org/apache/flink/statefun/playground/java/connectedcomponents/types/JavaType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/flink/statefun/playground/java/connectedcomponents/types/Types.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/flink/statefun/playground/java/connectedcomponents/ConnectedComponentsFn.java
Show resolved
Hide resolved
tillrohrmann
force-pushed
the
connectedComponents
branch
from
4921be5
to
9c666fd
Compare
|
Thanks for the review @igalshilman. I've addressed your comments and pushed an update. Merging this PR now into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example for calculating the connected components using Stateful Functions.
This PR needs to be ported to
devandrelease-3.2.