[FLINK-16985] Stateful Functions Examples have their specific job names

[UnityLung]

Stateful Functions Examples add their specific job names.

Greeter-example
Python-greeter-example
Python-kubernetes-example
Ridesharing-example
Shopping-cart-example

[UnityLung]

@tzulitai Can you please review it?

[igalshilman]

Hi there,
Thanks a lot for opening your first PR for this project, and welcome :-)

I think that everything we will put in the examples folks would accidentally think that this is mandatory and copy to their projects.
I’d really like the Dockerfile to stay as simple as possible at this moment, to lower the entrance barrier for StateFun.

Did you find the lack of a specific job name confusing for you?

[tzulitai]

I originally opened FLINK-16985.
I wouldn't say lacking the specific job name is confusing, but maybe rounds up a better user experience for new users who are just coming to this repo for the first time, running the application, and then looking at the Flink Web UI to see what's happening behind the scenes.

But I agree that adding this extra bit to the example Dockerfiles can be a bit distracting from a "introductory examples" point of view.

[igalshilman]

Hi @abc863377, I think that there is a consensus not to proceed with the change here, but I'd like to suggest the following: can you set the statefun.flink-job-name key at tools/docker/flink-distribution-template/conf/flink-conf.yaml so that people who would like to change the job name, would know what to modify.

The suggest change is to add:

statefun.flink-job-name: Statefun Application

[UnityLung]

Hi @igalshilman ,
Thanks for the suggestion. I'll follow your advice and keep Dockerfile simple.

[igalshilman]

Hi @abc863377,
Thanks for adding the statefun.flink-job-name configuration to the distribution template, this sets a good example!
However I thought we reached an agreement to not changing the Dockerfiles? can you please revert the change in the greeter example?
Other then that, I'm good with merging this!

[UnityLung]

Hi, @igalshilman ,
Sorry. I am a Git beginner.

Now I removed the old commit. and updated the new statefun.flink-job-name configuration to the distribution template.

Can you please review it?

Thanks a lot.

[igalshilman]

Hi @abc863377,
No worries, thanks a lot for your first contribution to this project!

[sjwiesman]

Merging . . .