Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15952] Replace the usage of a raw byte[] for keys in MultiplexedState #15

Closed
wants to merge 2 commits into from

Conversation

igalshilman
Copy link
Contributor

This PR address the problem, that when using Flink's heap state backend keys to a MapState can not be of a primitive array type.
This PR introduces a new Protobuf message to be used as a key in a multiplexed state context.

message MultiplexedStateKey {
    string function_namespace = 1;
    string function_type = 2;
    string state_name = 3;
    repeated bytes user_keys = 4;
}

Copy link
Contributor

@tzulitai tzulitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks for fixing this.

I'll give a local run with the greeter example, and then merge this if Travis agrees as well 👌

@tzulitai
Copy link
Contributor

tzulitai commented Feb 8, 2020

Local run of the greeter example works, and Travis is green as well.
Merging ...

@tzulitai tzulitai closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants