[FLINK-16838] Change base image name and apply versioning #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also change the image name from statefun to flink-statefun, to have a more consistent naming with other distributions like the Python SDK.
…version tag With this change, the quickstart archetype now always uses a specific image version. If the archetype is a released artifact, then the version tag used will be x.y.z, e.g. 2.0.0. Images in this case should be available in the Docker Hub registry. Otherwise, if the archetype is a snapshot distribution built from development branches, then the version tag used wil be snapshot versions, e.g. 2.1-SNAPSHOT. In this case, you would have to locally build the image from the corresponding source version.
tzulitai
commented
Mar 28, 2020
| @@ -13,7 +13,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| FROM statefun | |||
| FROM flink-statefun:2.1-SNAPSHOT | |||
There was a problem hiding this comment.
Note:
these will be changed to FROM flink-statefun:2.0-SNAPSHOT when backporting these changes to the snapshot release-2.0 branch.
On release candidates / releases, these will be e.g. FROM flink-statefun:2.0.0
There was a problem hiding this comment.
The updated update_branch_version.sh script takes care of updating these strings automatically.
igalshilman
approved these changes
Mar 28, 2020
|
Thanks for the fast review Igal. Merging ... |
tzulitai
added a commit
that referenced
this pull request
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following end-goal in mind:
masterorrelease-2.0branches) should always run against a locally-built StateFun base image, built from the source of said snapshot version.This PR does a few things to accomplish that:
Let the image build script
tools/docker/build-distribution.shbuild images tagged with the current source version. i.e.,2.1-SNAPSHOTwhen built from the snapshotmasterbranch,2.0-SNAPSHOTwhen built from the snapshotrelease-2.0branch, orsimply
2.0.0if built from a officially released source distributionUpdate Dockerfiles of all examples / E2E tests / quickstart archetype to use a specific version tag. This has the effect that, if those were built from a released distribution, the image may be pulled directly from Docker Hub (when we publish the images after the release). Otherwise, if those were built from a snapshot version, they would use a locally-built snapshot image.
On the side, this PR also uses the opportunity to rename the image name from
statefuntoflink-statefun, with the following reasoning:Verifying
I verified the changes by:
mvn clean verify -Prun-e2e-tests