[FLINK-17193] [k8s-python-example] build-example.sh improvements #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distribution if was not previously built
|
Hi @aroch, thank you for fixing this. I will go ahead and merge it. In the future, could you please open a Jira ticket for this type of change. It helps us keep track on of what is being worked on in the project. |
aroch
changed the title
|
Thank you! |
|
Thanks @sjwiesman! Just opened an issue and updated accordingly. Was not completely sure about filling the JIRA. Would appreciate if you can take a look. |
sjwiesman
pushed a commit
that referenced
this pull request
Apr 16, 2020
… distribution if was not previously built This closes #99
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm template was printed out instead of being redirected to the resource YAML file.
In case the SDK distribution was not previously built - instead of failing the build, build the distribution and continue.
Abort script on failure. Previously, on failure the script would continue to run all steps and finish in an erroneous state. Also this saves 'if' statements to check exit codes after commands execute.