Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23332] update gradle to 7.1 #21

Merged
merged 3 commits into from Jul 13, 2021
Merged

[FLINK-23332] update gradle to 7.1 #21

merged 3 commits into from Jul 13, 2021

Conversation

NicoK
Copy link
Contributor

@NicoK NicoK commented Jul 9, 2021

Also update the ' shadow' plugin accordingly.

NicoK added 3 commits July 9, 2021 15:29
This also requires a newer 'shadow' version.
Also, we actually only have the root project's description, so let's not set
it for all subprojects!
Copy link
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests, build, and check styles all work fine. LGTM. +1

@NicoK
Copy link
Contributor Author

NicoK commented Jul 12, 2021

You have to use the provided gradle wrapper script, not your system gradle version, otherwise you will see errors like this.
I have a commit in one of my branches which adds a few commands that will hopefully help, sounds like I should include this one or a note to use the gradle wrapper. (I'll create a pr after all these changes)

@alpinegizmo
Copy link
Contributor

The problem I'm having testing this is that I don't know how to get ./gradlew to clear the cache, so I'm not succeeding in seeing this do very much work. I'm frustrated that ./gradlew clean doesn't seem to work.

@alpinegizmo
Copy link
Contributor

I upgraded my system gradle 7.1.1, but the tests fail when I use it. They seem to pass when I use ./gradlew, but I'm not confident they are being run.

@NicoK NicoK merged commit 5c8386d into apache:master Jul 13, 2021
@NicoK NicoK deleted the f23332 branch July 13, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants