[FLINK-11567] Translate "How to Review a Pull Request" page into Chinese #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packbase
reviewed
Feb 26, 2019
|
|
||
| **A contribution is well-described if the following questions 2, 3, and 4 can be answered without looking at the code.** | ||
| **如果在不查看代码的情况下能回答以下问题2、3、4，则该贡献得到了很好的描述。** |
|
|
||
| **A feature, improvement, or bug fix is approved once one committer accepts it and no committer disagrees (lazy consensus).** | ||
| **一旦有一个 committer 接受了某个功能、改进或者错误修复，并且没有其他 committer 不同意（lazy consensus 机制），那么就会批准它。** |
There was a problem hiding this comment.
那么就会批准它。
->
那么该特性、改进或错误修复就会得到批准。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate "How to Review a Pull Request" page into Chinese.
The markdown file is located in: flink-web/reviewing-prs.zh.md
The url link is: https://flink.apache.org/zh/reviewing-prs.html
Notes: This PR has fixed all the problems from "#171". Because of my improper operation, the PR of "#171" can not be changed any more. Thank you for your understanding.