Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Season of Docs Blog Post #202

Closed
wants to merge 1 commit into from
Closed

Added Season of Docs Blog Post #202

wants to merge 1 commit into from

Conversation

knaufk
Copy link
Contributor

@knaufk knaufk commented Apr 17, 2019

@knaufk knaufk force-pushed the sod-blogpost branch 2 times, most recently from 70974c1 to fc8e9b1 Compare April 17, 2019 16:37
fhueske
fhueske reviewed Apr 17, 2019
View reviewed changes
Copy link
Contributor

@fhueske fhueske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @knaufk!
I think it read well. I've added a few comments.

Thanks, Fabian

_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
@knaufk knaufk force-pushed the sod-blogpost branch 2 times, most recently from ed0b565 to b6161aa Compare April 17, 2019 17:04
sjwiesman
sjwiesman reviewed Apr 17, 2019
View reviewed changes
Copy link
Contributor

@sjwiesman sjwiesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative on this @knaufk, I've made a few suggestions on a few of the sections.

_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
@knaufk knaufk force-pushed the sod-blogpost branch 2 times, most recently from 3f178e2 to 44da60e Compare April 17, 2019 17:15
@knaufk
Copy link
Contributor Author

knaufk commented Apr 17, 2019

@sjwiesman @fhueske Thank you for your reviews. I have addressed all comments.

@sunjincheng121 sunjincheng121 self-assigned this Apr 17, 2019
sunjincheng121
sunjincheng121 reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@sunjincheng121 sunjincheng121 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @knaufk!
LGTM. I only left the last 3 suggestions!

Best,
Jincheng

_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
wuchong
wuchong reviewed Apr 18, 2019
View reviewed changes
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knaufk , I left a few minor comments.

_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
_posts/2019-04-17-sod.md Show resolved Hide resolved
_posts/2019-04-17-sod.md Outdated Show resolved Hide resolved
rmetzger
rmetzger reviewed Apr 18, 2019
View reviewed changes
_posts/2019-04-17-sod.md Outdated
twitter: "snntrable"
---

The Apache Flink community is happy to announce its application to the first edition of [Season of Docs](https://developers.google.com/season-of-docs/) by Google. The program is bringing together Open Source projects and technical writers to raise awareness for and improve documentation of Open Source projects. We would like to take this chance to work with one or two technical writers for three months to improve and restructure parts of [our documentation](https://ci.apache.org/projects/flink/flink-docs-stable/) (details below).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to take this chance to work with one or two technical writers for three months to improve and restructure parts of

This sounds a bit like we would only like to work with 2 writers in general.
Maybe we should add a sentence somewhere in the text that invites everybody to contribute to the Flink documentation, outside of the SoD program?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the first paragraph. What do you think?

@knaufk
Copy link
Contributor Author

knaufk commented Apr 18, 2019

@fhueske @wuchong @sunjincheng121 @rmetzger I have addressed all comments and set the publish date to today.

@sunjincheng121
Copy link
Member

Thanks for the update! @knaufk
+1 to merged.
Best, Jincheng

sunjincheng121 pushed a commit to sunjincheng121/flink-web that referenced this pull request Apr 18, 2019
@knaufk @sunjincheng121
Added sod blog post.
4f9b711 
This closes apache#202
@sunjincheng121
Copy link
Member

Merged, and have rebuild the website.

XComp pushed a commit to XComp/flink-web that referenced this pull request Sep 7, 2020
@knaufk @XComp
Added sod blog post.
20d217e 
This closes apache#202
curcur pushed a commit to curcur/flink-web that referenced this pull request Apr 5, 2021
@knaufk @curcur
Added sod blog post.
c8a57f4 
This closes apache#202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmetzger rmetzger rmetzger left review comments

@fhueske fhueske fhueske left review comments

@wuchong wuchong wuchong left review comments

@sunjincheng121 sunjincheng121 sunjincheng121 left review comments

@sjwiesman sjwiesman sjwiesman approved these changes

Assignees

@sunjincheng121 sunjincheng121

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@knaufk @sunjincheng121 @rmetzger @sjwiesman @fhueske @wuchong