Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4585] Fix broken links in index.md #34

Closed
wants to merge 1 commit into from

Conversation

apivovarov
Copy link
Contributor

@rmetzger
Copy link
Contributor

rmetzger commented Sep 6, 2016

Thanks a lot for fixing the broken links.
+1 to merge (the merger should check again using local preview)

@apivovarov
Copy link
Contributor Author

Hi Robert, can you merge it? @rmetzger

@rmetzger
Copy link
Contributor

rmetzger commented Sep 7, 2016

Yes, I usually like to wait for at least one other committer to confirm. But it has been open for 24 hours, so I assume there was enough time for others to notice the change :)

I'll merge it now

@asfgit asfgit closed this in bb6d820 Sep 7, 2016
@apivovarov
Copy link
Contributor Author

@rmetzger IMHO there is no need for the second +1 on ASF projects. Yes, committer has to wait 24 hours after +1 to commit.

@rmetzger
Copy link
Contributor

Yes, there is no need. Its just that I like to have a second confirmation before merging ;)

XComp pushed a commit to XComp/flink-web that referenced this pull request Sep 7, 2020
curcur pushed a commit to curcur/flink-web that referenced this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants