Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flink-ml 2.0.0 #493

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Add flink-ml 2.0.0 #493

merged 2 commits into from
Jan 7, 2022

Conversation

gaoyunhaii
Copy link
Contributor

This PR updates the documents to include the downloads information for the upcoming flink-ml 2.0.0

downloads.md Outdated Show resolved Hide resolved
downloads.md Outdated
</dependency>
```

flink-ml-uber_2.12 provides all the dependencies needed to use Flink ML. Alternatively, advanced users could use the following artifacts to import a minimal set of Flink ML dependencies for their target use-cases:
Copy link
Contributor

@zhipeng93 zhipeng93 Dec 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that flink-ml-uber_2.12 only includes flink-ml-core and flink-ml-iteration [1]. Do you mean to include all other dependencies in flink-ml?

[1] https://github.com/apache/flink-ml/blob/master/flink-ml-uber/pom.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhipeng93 I think you are right, I removed dependency of flink-ml-uber currently and use directly the direct dependencies . We could re-enabled the uber jar in the next version.

_config.yml Show resolved Hide resolved
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @gaoyunhaii. I think this PR is missing the rebuild commit.

@gaoyunhaii gaoyunhaii force-pushed the r_ml_2.0.0 branch 3 times, most recently from 85d530e to 8b1ff41 Compare January 4, 2022 07:20
@gaoyunhaii
Copy link
Contributor Author

Very thanks @tillrohrmann for the review! I add the rebuild commit now~

_config.yml Outdated Show resolved Hide resolved
Copy link
Member

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also update ./content/zh/downloads.html? Thanks!

_config.yml Outdated Show resolved Hide resolved
@gaoyunhaii
Copy link
Contributor Author

@lindong28 I added the translation~

@lindong28
Copy link
Member

@gaoyunhaii Thanks for the update! I have checked both http://0.0.0.0:4000/downloads.html and http://0.0.0.0:4000/zh/downloads.html locally and the pages LGTM.

@dianfu dianfu merged commit cfb62f3 into apache:asf-site Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants