[FLINK-30768] [Project Website] flink-web version cleanup

[victor09091]

What is the purpose of the change

update versions (through variables) and adding references that these variables have to be updated to the corresponding versions that used in the Flink source code as well.

Brief change log

• *modify q/gradle-quickstart.sh and q/sbt-quickstart.sh, *

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)

[XComp]

Thanks for picking this up, @victor9309 . I added two comments. I'm curious about your opinion on that. PTAL

[victor09091]

Thanks @XComp for the review. modify _include/q/gradle-quickstart.sh and extend the list variable that's already present in docs/config.toml

[XComp]

Thanks for addressing my comments. I have a few things that we need to address still. PTAL

[victor09091]

Thanks @XComp for the review.
I validate the return value, but I don't know if I need to exit the shell script or print if there is no valid value.
Test no valid value：

I changed the config directory, please check to see if it is correct

[victor09091]

Thanks @XComp for the review. Thank you very much for your advice.

$ cat foo-utils.sh 
function foo() {
  echo 'foo...........' >&2
  exit 1
}
$ cat foo-main.sh 
source ./foo-utils.sh

v=$(foo)
echo "$v"
echo "end-------------"

I found that exit 1 in the function can not exit the script, so I modify the logic, please check it

$ cat foo-utils.sh 
export TOP_PID=$$
trap 'exit 1' TERM
function foo() {
   echo 'foo...........' >&2
   kill -s TERM $TOP_PID
}

$ cat foo-main.sh 
source ./foo-utils.sh

v=$(foo)
echo "$v"
echo "end-------------"

[XComp]

I did another thorough pass over it. PTAL

Just as a heads-up: There should be a conflict in this PR popping up soon because of the 1.18.0 release happening right now.

[XComp]

Suggested change

	export TOP_PID=$$
	# fatal error handling
	export PROCESS_PID=$$

[XComp]

You missed the renaming of the variable. I'm not sure what TOP stands for in this context. 🤔 Alternatively, you can replace "TOP" with the long version of this acronym.

[victor09091]

Thanks @XComp for the review. I really feel what you're suggesting

[XComp]

Looks good. Thank you. :-) Just a minor discussion point on the variable name.

[XComp]

You missed the renaming of the variable. I'm not sure what TOP stands for in this context. 🤔 Alternatively, you can replace "TOP" with the long version of this acronym.

[XComp]

I don't know why it didn't occur to me before but ./quickstart-scala.sh is failing since 1.17. This is because we removed scala support in 1.17. I created FLINK-33383 to cover this issue.

[victor09091]

Thanks @XComp for the review. I changed the variable; If _includes/q/quickstart-scala.sh and _includes/q/quickstart-scala-SNAPSHOT.sh are removed, and if 1.7+ is not supported; Do you think that's okay if I don't make any changes?

[XComp]

LGTM 👍 I added a few separate commits (e.g. reverting the log4j/slft4j version changes because I noticed that we don't necessarily have to align this version with the versions used in Flink). I felt bad to let you do this change again. That is why I did that in the end. I pushed the changes for transparency reasons.

I will squash the commits and rebuild the website. Thanks for your help 👍