Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-8299][flip6] Retrieve JobExecutionResult after job submission
[FLINK-8299][flip6] Improve ExponentialWaitStrategy Add additional argument validation. Add more unit tests. This closes #5207.
- Loading branch information
1 parent
e2f1ba9
commit 0692275
Showing
7 changed files
with
424 additions
and
109 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
...nts/src/main/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategy.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.client.program.rest.retry; | ||
|
||
import static org.apache.flink.util.Preconditions.checkArgument; | ||
|
||
/** | ||
* {@link WaitStrategy} with exponentially increasing sleep time. | ||
*/ | ||
public class ExponentialWaitStrategy implements WaitStrategy { | ||
|
||
private final long initialWait; | ||
|
||
private final long maxWait; | ||
|
||
public ExponentialWaitStrategy(final long initialWait, final long maxWait) { | ||
checkArgument(initialWait > 0, "initialWait must be positive, was %s", initialWait); | ||
checkArgument(maxWait > 0, "maxWait must be positive, was %s", maxWait); | ||
checkArgument(initialWait <= maxWait, "initialWait must be lower than or equal to maxWait", maxWait); | ||
this.initialWait = initialWait; | ||
this.maxWait = maxWait; | ||
} | ||
|
||
@Override | ||
public long sleepTime(final long attempt) { | ||
checkArgument(attempt >= 0, "attempt must not be negative (%d)", attempt); | ||
final long exponentialSleepTime = initialWait * Math.round(Math.pow(2, attempt)); | ||
return exponentialSleepTime >= 0 && exponentialSleepTime < maxWait ? exponentialSleepTime : maxWait; | ||
} | ||
} |
35 changes: 35 additions & 0 deletions
35
flink-clients/src/main/java/org/apache/flink/client/program/rest/retry/WaitStrategy.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.flink.client.program.rest.retry; | ||
|
||
/** | ||
* Operations that are polling for a result to arrive require a waiting time between consecutive | ||
* polls. A {@code WaitStrategy} determines this waiting time. | ||
*/ | ||
@FunctionalInterface | ||
public interface WaitStrategy { | ||
|
||
/** | ||
* Returns the time to wait until the next attempt. Attempts start at {@code 0}. | ||
* @param attempt The number of the last attempt. | ||
* @return Waiting time in ms. | ||
*/ | ||
long sleepTime(long attempt); | ||
|
||
} |
Oops, something went wrong.