[FLINK-20850][runtime] Renames method

CoLocationGroupDesc.getVertices was renamed: The refactoring changed the return type and, therefore, made the renaming necessary. FLINK-20589
apache · Jan 8, 2021 · 4393af4 · 4393af4
1 parent 4358aaf
commit 4393af4
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/...-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroup.java b/...-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroup.java
@@ -52,7 +52,7 @@ public void addVertex(JobVertex vertex) {
     }
 
     @Override
-    public List<JobVertexID> getVertices() {
+    public List<JobVertexID> getVertexIDs() {
         return vertices.stream().map(JobVertex::getID).collect(ImmutableList.toImmutableList());
     }
 

diff --git a/...time/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroupDesc.java b/...time/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroupDesc.java
@@ -46,7 +46,7 @@ public interface CoLocationGroupDesc {
      *
      * @return The group's members represented by their {@link JobVertexID}s.
      */
-    List<JobVertexID> getVertices();
+    List<JobVertexID> getVertexIDs();
 
     /**
      * Returns the {@link CoLocationConstraintDesc} for a specific {@code subTaskIndex}.

diff --git a/.../main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java b/.../main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java
@@ -117,7 +117,7 @@ private ExecutionSlotSharingGroupBuilder(
 
             this.coLocationGroupMap = new HashMap<>();
             for (CoLocationGroupDesc coLocationGroup : coLocationGroups) {
-                for (JobVertexID jobVertexId : coLocationGroup.getVertices()) {
+                for (JobVertexID jobVertexId : coLocationGroup.getVertexIDs()) {
                     coLocationGroupMap.put(jobVertexId, coLocationGroup);
                 }
             }

diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobGraphTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobGraphTest.java
@@ -444,6 +444,6 @@ public void testGetCoLocationGroupDescriptors() {
         final CoLocationGroupDesc onlyCoLocationGroupDesc =
                 jobGraph.getCoLocationGroupDescriptors().iterator().next();
         assertThat(
-                onlyCoLocationGroupDesc.getVertices(), containsInAnyOrder(v1.getID(), v2.getID()));
+                onlyCoLocationGroupDesc.getVertexIDs(), containsInAnyOrder(v1.getID(), v2.getID()));
     }
 }
diff --git a/...va/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java b/...va/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
@@ -819,10 +819,10 @@ public void testIteration() {
             if (jobVertex.getName().startsWith(StreamGraph.ITERATION_SOURCE_NAME_PREFIX)) {
                 iterationSourceCoLocationGroup = jobVertex.getCoLocationGroup();
                 assertTrue(
-                        iterationSourceCoLocationGroup.getVertices().contains(jobVertex.getID()));
+                        iterationSourceCoLocationGroup.getVertexIDs().contains(jobVertex.getID()));
             } else if (jobVertex.getName().startsWith(StreamGraph.ITERATION_SINK_NAME_PREFIX)) {
                 iterationSinkCoLocationGroup = jobVertex.getCoLocationGroup();
-                assertTrue(iterationSinkCoLocationGroup.getVertices().contains(jobVertex.getID()));
+                assertTrue(iterationSinkCoLocationGroup.getVertexIDs().contains(jobVertex.getID()));
             } else {
                 assertNull(jobVertex.getCoLocationGroup());
             }