Skip to content

Commit

Permalink
Feedback addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
twalthr committed Feb 15, 2018
1 parent 7e18fbf commit 4900491
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,4 @@ public ObjectNode deserialize(byte[] message) throws IOException {
}
return mapper.readValue(message, ObjectNode.class);
}

@Override
public boolean isEndOfStream(ObjectNode nextElement) {
return false;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
/**
* Deserialization schema from JSON to Flink types.
*
* <p>Deserializes the <code>byte[]</code> messages as a JSON object and reads
* <p>Deserializes a <code>byte[]</code> message as a JSON object and reads
* the specified fields.
*
* <p>Failure during deserialization are forwarded as wrapped IOExceptions.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@
* <p>Note: This converter implements just a subset of the JSON schema specification.
* Union types (as well as "allOf", "anyOf", "not") are not supported yet. Simple
* references that link to a common definition in the document are supported. "oneOf" and
* arrays of type are only supported for specifying nullability;
* arrays of type are only supported for specifying nullability.
*
* <p>This converter has been developed for JSON Schema draft-07 but also includes keywords of
* older drafts to be as compatible as possible.
*/
@SuppressWarnings("OptionalIsPresent")
public final class JsonSchemaConverter {
Expand Down Expand Up @@ -86,7 +89,7 @@ private JsonSchemaConverter() {
private static final String CONTENT_ENCODING_BASE64 = "base64";

/**
* Converts a JSON schema into Flink's type information. Throws an exception of the schema
* Converts a JSON schema into Flink's type information. Throws an exception if the schema
* cannot converted because of loss of precision or too flexible schema.
*
* <p>The converter can resolve simple schema references to solve those cases where entities
Expand Down

0 comments on commit 4900491

Please sign in to comment.