Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[hotfix] Include Hadoop version into EnvironmentInformation
- Loading branch information
Showing
2 changed files
with
12 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
554b77b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some points there were thoughts about a "hadoop-free" version. How would this play together?
554b77b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, flink-runtime has a dependency on Hadoop, so I can assume its always available.
Even for a binary Flink release without build in Hadoop dependencies, we would assume Hadoop to be present (from the classpath).
For a Flink release without any Hadoop, we can either remove this again or use some reflection / fake hadoop class magic (added via maven) if needed.
But for now, I would like to have this in the code base because it helps debugging user issues.
554b77b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good addition. In the future (Hadoop not present), we may have to go for reflection, true.