[FLINK-27885][tests][JUnit5 migration] Harden access modifiers

apache · Mar 30, 2023 · 6c7bde1 · 6c7bde1
1 parent f630e47
commit 6c7bde1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/...v/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java b/...v/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java
@@ -34,16 +34,16 @@
 /**
  * Test for statistics functionality in {@link CsvFormatFactory} in the case of file system source.
  */
-public class CsvFormatFilesystemStatisticsReportTest extends CsvFormatStatisticsReportTest {
+class CsvFormatFilesystemStatisticsReportTest extends CsvFormatStatisticsReportTest {
 
+    @Override
     @BeforeEach
     public void setup(@TempDir File file) throws Exception {
         super.setup(file);
     }
 
     @Test
-    public void testCsvFileSystemStatisticsReport()
-            throws ExecutionException, InterruptedException {
+    void testCsvFileSystemStatisticsReport() throws ExecutionException, InterruptedException {
         // insert data and get statistics by get plan.
         DataType dataType = tEnv.from("sourceTable").getResolvedSchema().toPhysicalRowDataType();
         tEnv.fromValues(dataType, getData()).executeInsert("sourceTable").await();

diff --git a/...s/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatStatisticsReportTest.java b/...s/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatStatisticsReportTest.java
@@ -41,10 +41,11 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 /** Test for statistics functionality in {@link CsvFormatFactory}. */
-public class CsvFormatStatisticsReportTest extends StatisticsReportTestBase {
+class CsvFormatStatisticsReportTest extends StatisticsReportTestBase {
 
     private static CsvFileFormatFactory.CsvBulkDecodingFormat csvBulkDecodingFormat;
 
+    @Override
     @BeforeEach
     public void setup(@TempDir File file) throws Exception {
         super.setup(file);
@@ -61,7 +62,7 @@ protected String[] properties() {
     }
 
     @Test
-    public void testCsvFormatStatsReportWithSingleFile() throws Exception {
+    void testCsvFormatStatsReportWithSingleFile() throws Exception {
         // insert data and get statistics.
         DataType dataType = tEnv.from("sourceTable").getResolvedSchema().toPhysicalRowDataType();
         tEnv.fromValues(dataType, getData()).executeInsert("sourceTable").await();
@@ -75,7 +76,7 @@ public void testCsvFormatStatsReportWithSingleFile() throws Exception {
     }
 
     @Test
-    public void testCsvFormatStatsReportWithMultiFile() throws Exception {
+    void testCsvFormatStatsReportWithMultiFile() throws Exception {
         // insert data and get statistics.
         DataType dataType = tEnv.from("sourceTable").getResolvedSchema().toPhysicalRowDataType();
         tEnv.fromValues(dataType, getData()).executeInsert("sourceTable").await();
@@ -91,7 +92,7 @@ public void testCsvFormatStatsReportWithMultiFile() throws Exception {
     }
 
     @Test
-    public void testRowSizeBiggerThanTotalSampleLineCnt() throws IOException {
+    void testRowSizeBiggerThanTotalSampleLineCnt() throws IOException {
         StringBuilder builder = new StringBuilder();
         int lineCnt = 1000;
         for (int i = 0; i < lineCnt; i++) {
@@ -104,7 +105,7 @@ public void testRowSizeBiggerThanTotalSampleLineCnt() throws IOException {
     }
 
     @Test
-    public void testCsvFormatStatsReportWithEmptyFile() {
+    void testCsvFormatStatsReportWithEmptyFile() {
         TableStats tableStats = csvBulkDecodingFormat.reportStatistics(null, null);
         assertThat(tableStats).isEqualTo(TableStats.UNKNOWN);
     }