[FLINK-7254] [java8] Properly activate checkstyle for flink-java8

apache · Jul 25, 2017 · 7ce2a93 · 7ce2a93
1 parent b139147
commit 7ce2a93
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/flink-java8/pom.xml b/flink-java8/pom.xml
@@ -35,10 +35,6 @@ under the License.
 
 	<packaging>jar</packaging>
 
-	<properties>
-		<checkstyle.skip>true</checkstyle.skip>
-	</properties>
-
 	<dependencies>
 
 		<!-- core dependencies -->

diff --git a/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java b/flink-java8/src/test/java/org/apache/flink/api/java/type/lambdas/LambdaExtractionTest.java
@@ -327,7 +327,7 @@ public void testConstructorMethodRef() {
 		Assert.assertEquals(BasicTypeInfo.INT_TYPE_INFO, ti);
 	}
 
-	public interface InterfaceWithDefaultMethod {
+	private interface InterfaceWithDefaultMethod {
 		void samMethod();
 
 		default void defaultMethod() {
@@ -342,7 +342,7 @@ public void testSamMethodExtractionInterfaceWithDefaultMethod() {
 		assertEquals("samMethod", sam.getName());
 	}
 
-	public interface InterfaceWithMultipleMethods {
+	private interface InterfaceWithMultipleMethods {
 		void firstMethod();
 
 		void secondMethod();
@@ -353,18 +353,18 @@ public void getSingleAbstractMethodMultipleMethods() throws Exception {
 		TypeExtractionUtils.getSingleAbstractMethod(InterfaceWithMultipleMethods.class);
 	}
 
-	public interface InterfaceWithoutAbstractMethod {
+	private interface InterfaceWithoutAbstractMethod {
 		default void defaultMethod() {
 
-		};
+		}
 	}
 
 	@Test(expected = InvalidTypesException.class)
 	public void getSingleAbstractMethodNoAbstractMethods() throws Exception {
 		TypeExtractionUtils.getSingleAbstractMethod(InterfaceWithoutAbstractMethod.class);
 	}
 
-	public abstract class AbstractClassWithSingleAbstractMethod {
+	private abstract class AbstractClassWithSingleAbstractMethod {
 		public abstract void defaultMethod();
 	}
 

diff --git a/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java b/flink-java8/src/test/java/org/apache/flink/cep/CEPLambdaTest.java
@@ -27,7 +27,6 @@
 import org.apache.flink.util.Collector;
 import org.apache.flink.util.TestLogger;
 
-import org.junit.Ignore;
 import org.junit.Test;
 
 import java.util.List;

diff --git a/flink-java8/src/test/resources/log4j-test.properties b/flink-java8/src/test/resources/log4j-test.properties
@@ -16,4 +16,4 @@
 # limitations under the License.
 ################################################################################
 
-log4j.rootLogger=OFF
+log4j.rootLogger=OFF