fixup! [FLINK-20663][core] Forbid calling HybridMemorySegment#wrap on…

… unsafe segments.
apache · Feb 14, 2021 · d1936a8 · d1936a8
1 parent 5cc7dbc
commit d1936a8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/flink-core/src/main/java/org/apache/flink/core/memory/HybridMemorySegment.java b/flink-core/src/main/java/org/apache/flink/core/memory/HybridMemorySegment.java
@@ -62,6 +62,11 @@ public final class HybridMemorySegment extends MemorySegment {
 
     @Nullable private final Runnable cleaner;
 
+    /**
+     * Wrapping is not allowed when the underlying memory is unsafe. Unsafe memory can be actively
+     * released, without reference counting. Therefore, access from wrapped buffers, which may not
+     * be aware of the releasing of memory, could be risky.
+     */
     private final boolean allowWrap;
 
     /**