Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11466][e2e] Design the e2e java framework so that the Kafka streaming tests and Kafka SQL tests can running on it #10042

Closed
wants to merge 6 commits into from

Conversation

openinx
Copy link
Member

@openinx openinx commented Oct 30, 2019

What is the purpose of the change

Rewrite the e2e kafka related test by Java, so that we can move the FLINK-11463 forward. it need to meet the following requirement:

  1. Should abstract the Flink resources, and provide standalone implementation & distribution implementation, so that the test can run on different flink env.
  2. Should abstract the Kafka resource, and provide standalone implementation at least, can leave the distribution impl as dummy because seems we're not depending on it now.
  3. Will provide the file cache later , not in this PR because it's seems big enough now, another PR will be better for reviewing.
  4. Set different catalog for each e2e test case, so that we can configure to decide whether to run the given test in diff nightly case ( no need to run most of the e2e test in precommit env). it will be another PR.

Brief change log

  • 4b43f87 Introduce the rough java framework for flink end-to-end testing
  • b523eac Define the KafkaDistribution and its behavior, so that the upper layer e2e java framework can depends on it.
  • 876f0f8 Add the kafka streaming end-to-end tests
  • 4108e40 Abstract the KafkaResource so that the e2e test can run on both standalone cluster and distributed cluster, currently the distributed kafka resource is still in TODO state.

Verifying this change

This change added tests and can be verified as follows:

mvn package test \     
-DdistDir=/Users/openinx/software/flink/build-target \
-De2e.flink.mode=localStandalone \
-De2e.kafka.mode=localStandalone \
-Dtest=TestSQLClientKafka,TestSQLClientKafka010,TestSQLClientKafka011,TestStreamingKafka,TestStreamingKafka010,TestStreamingKafka011  \
-pl org.apache.flink:flink-end-to-end-tests-common

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 30, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 123c831 (Wed Dec 04 14:59:19 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 30, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@openinx openinx changed the title [FLINK-11466][e2e] Implement LocalStandaloneKafkaResource [FLINK-11466][e2e] Design the e2e java framework so that the Kafka streaming tests and Kafka SQL tests can running on it Nov 4, 2019
…alone cluster and distributed cluster, currently the distributed kafka resource is still in TODO state.
@openinx
Copy link
Member Author

openinx commented Nov 5, 2019

Ping @tillrohrmann @zentol for reviewing ..

@openinx
Copy link
Member Author

openinx commented Nov 6, 2019

The e2e framework will build based on the previous PR from @zentol (#7605), so close this one now. and I will fix all the conflicts in @zentol 's PR and create a new one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants