[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions #10216

dawidwys · 2019-11-15T10:39:09Z

What is the purpose of the change

Use typed ConfigOptions for RestartStrategyOptions. The options can be changed directly without deprecating first, because they haven't been released yet. Those options were introduced in 1.10.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…ptions in RestartStrategyOptions

flinkbot · 2019-11-15T10:41:49Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 304d091 (Wed Dec 04 15:23:33 UTC 2019)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2019-11-15T11:32:00Z

CI report:

283e9a5 : SUCCESS Build
304d091 : FAILURE Build

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build

zentol · 2019-11-15T13:56:56Z

...rc/test/java/org/apache/flink/runtime/executiongraph/restart/RestartStrategyFactoryTest.java

@@ -61,7 +61,7 @@ public void createRestartStrategyFactory_fixedDelayRestartStrategyConfigured_ret
 		final Configuration configuration = new Configuration();
 		configuration.setString(RestartStrategyOptions.RESTART_STRATEGY, "fixed-delay");
 		configuration.setInteger(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_ATTEMPTS, attempts);
-		configuration.setString(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_DELAY, delayBetweenRestartAttempts.getSeconds() + "s");
+		configuration.setString(RestartStrategyOptions.RESTART_STRATEGY_FIXED_DELAY_DELAY.key(), delayBetweenRestartAttempts.getSeconds() + "s");


Wondering whether we should just use a Duration here.

We can yes. It will no longer test the string parsing, but it does not have to. The parsing is covered in the Configuration tests.

zentol · 2019-11-15T13:58:52Z

flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java

@@ -162,6 +162,14 @@ public boolean equals(Object obj) {
 			}
 		}

+		@Override
+		public String toString() {
+			return "FixedDelayRestartStrategyConfiguration{" +


Why is this being added? (and why not also for the other configurations?)

You are right. I should've added it to all classes. I added it for debugging.

I added a common implementation to the base class that reuses the description.

zentol · 2019-11-15T15:05:53Z

docs/_includes/generated/failure_rate_restart_strategy_configuration.html

            <td>Delay between two consecutive restart attempts if <span markdown="span">`restart-strategy`</span> has been set to <span markdown="span">`failure-rate`</span>. It can be specified using notation: "1 min", "20 s"</td>
        </tr>
        <tr>
            <td><h5>restart-strategy.failure-rate.failure-rate-interval</h5></td>
-            <td style="word-wrap: break-word;">"1 min"</td>
-            <td>String</td>
+            <td style="word-wrap: break-word;">60000ms</td>


as a future note for the generator, if the value in milliseconds is a lot larger we may want to display this in seconds/minutes instead.

zentol

+1

[FLINK-14750][configuration] Migrate duration and memory size ConfigO…

f12c7e2

…ptions in RestartStrategyOptions

rmetzger added the review=description? label Nov 15, 2019

dawidwys mentioned this pull request Nov 15, 2019

[FLINK-14786][configuration] Add configure method to ExecutionConfig #10217

Closed

rmetzger added component=Documentation component=Runtime/Configuration labels Nov 15, 2019

zentol reviewed Nov 15, 2019

View reviewed changes

zentol self-assigned this Nov 15, 2019

dawidwys added 2 commits November 15, 2019 15:15

Comments addressed

9aad311

[FLINK-14750][documentation] Regenerated restart strategy documentation

304d091

dawidwys force-pushed the flink-14750 branch from 283e9a5 to 304d091 Compare November 15, 2019 14:15

zentol reviewed Nov 15, 2019

View reviewed changes

zentol approved these changes Nov 15, 2019

View reviewed changes

dawidwys closed this in 6c4dfcf Nov 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions #10216

[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions #10216

dawidwys commented Nov 15, 2019

flinkbot commented Nov 15, 2019 •

edited

flinkbot commented Nov 15, 2019 •

edited

zentol Nov 15, 2019

dawidwys Nov 15, 2019

zentol Nov 15, 2019

dawidwys Nov 15, 2019 •

edited

zentol Nov 15, 2019

zentol left a comment

[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions #10216

[FLINK-14750][configuration] Migrate duration and memory size ConfigOptions in RestartStrategyOptions #10216

Conversation

dawidwys commented Nov 15, 2019

What is the purpose of the change

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Nov 15, 2019 • edited

Automated Checks

Review Progress

flinkbot commented Nov 15, 2019 • edited

CI report:

zentol Nov 15, 2019

Choose a reason for hiding this comment

dawidwys Nov 15, 2019

Choose a reason for hiding this comment

zentol Nov 15, 2019

Choose a reason for hiding this comment

dawidwys Nov 15, 2019 • edited

Choose a reason for hiding this comment

zentol Nov 15, 2019

Choose a reason for hiding this comment

zentol left a comment

Choose a reason for hiding this comment

flinkbot commented Nov 15, 2019 •

edited

flinkbot commented Nov 15, 2019 •

edited

dawidwys Nov 15, 2019 •

edited