-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-14904][table] Rename ANY type to RAW type #10308
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 13737b1 (Wed Dec 04 15:53:57 UTC 2019) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
DataTypesTest.class}, | ||
|
||
{ANY(Void.class, VoidSerializer.INSTANCE), | ||
new AnyType<>(Void.class, VoidSerializer.INSTANCE), | ||
{DataTypes.RAW(Void.class, VoidSerializer.INSTANCE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: DataTypes.RAW
-> RAW
val genericType: TypeInformationAnyType[_], | ||
val nullable: Boolean, | ||
typeSystem: RelDataTypeSystem) | ||
val genericType: TypeInformationRawType[_], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is the additional indent necessary?
Thank you @dawidwys. Merging... |
What is the purpose of the change
Renames the
ANY
type toRAW
type.Brief change log
Updates docs, parser, logical types, and API.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: yesDocumentation