Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14104][build] Upgrade to flink-shaded 9.0 #10363

Merged
merged 2 commits into from Dec 5, 2019
Merged

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Nov 29, 2019

No description provided.

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 29, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 29f293a (Wed Dec 04 16:55:32 UTC 2019)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 29, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@StephanEwen
Copy link
Contributor

Do we need to adjust any NOTICE files due to the changed dependency versions we get, or is this automatically merged from flink-shaded?

@zentol
Copy link
Contributor Author

zentol commented Dec 4, 2019

This happens automatically. We don't list flink dependencies in our notice files (that's why flink-dist NOTICE remains unchanged) and the licensing for the binary is generated.

@tillrohrmann tillrohrmann self-assigned this Dec 4, 2019
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@zentol zentol merged commit da9268c into apache:master Dec 5, 2019
@zentol zentol deleted the 14104_m branch December 5, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants