[FLINK-15050][table-planner-blink] DataFormatConverters should suppor…

[docete]

…t any TIMESTAMP WITHOUT TIME ZONE types

What is the purpose of the change

User may pass any TIMESTAMP WITHOUT TIME ZONE in, e.g.:

DataTypes.TIMESTAMP(9).bridgedTo(LocalDateTime.class),
DataTypes.TIMESTAMP(9).bridgedTo(Timestamp.class),
DataTypes.TIMESTAMP(3),
new AtomicDataType(
  new LegacyTypeInformationType<>(
    LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE,
    SqlTimeTypeInfo.TIMESTAMP))
,
new AtomicDataType(
  new LegacyTypeInformationType<>(
    LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE,
    new LegacyTimestampTypeInfo(7)))

In such situations, we should return proper converters.

Brief change log

• Let DataFormatConverters support any TIMESTAMP_WITHOUT_TIME_ZONE types
• Add tests to verify

Verifying this change

This change is already covered by existing tests, such as DataFormatConvertersTest).

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6951e77 (Wed Dec 04 09:40:28 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[JingsongLi]

Let's remove SqlTimeTypeInfo and LocalTimeTypeInfo, precision 3 is a temporary solution, and should not reach here.

[docete]

The SqlTimeTypeInfo and LocalTimeTypeInfo are mapping to Timestamp(3) in LegacyTypeInfoDataTypeConverter now, should we keep consistent with that?

[docete]

OK, we follow the definition in TimestampType, using 6 as the default precision.

[JingsongLi]

You should add SqlTimestamp too.

[flinkbot]

CI report:

• 6951e77 Travis: FAILURE
• eeabfcb Travis: FAILURE
• f7b34fc Travis: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[JingsongLi]

LGTM after travis success.

[wuchong]

LGTM.

Will merge this once travis is passed again.