Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-14407][yarn] Retry S3 tests on failure #10445

Merged
merged 1 commit into from Dec 6, 2019
Merged

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Dec 5, 2019

Adds a RetryRule to the YarnFileStageTestS3ITCase to alleviate issues when read-after-write operations aren't as reliable as we'd like them to be.

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 5, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9709c3c (Thu Dec 05 14:49:55 UTC 2019)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 5, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build

@StephanEwen
Copy link
Contributor

Looks good, +1 to merge

BTW: The presto s3 fs should not have these visibility issues, so we should only use retries with s3a and s3n.

@zentol
Copy link
Contributor Author

zentol commented Dec 6, 2019

Good to know, I'll try to keep that in mind!

@zentol zentol merged commit 7de2e46 into apache:master Dec 6, 2019
@zentol zentol deleted the 14407 branch December 6, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants