Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15089][connectors] Puslar catalog #10455

Closed
wants to merge 2 commits into from

Conversation

yjshen
Copy link
Member

@yjshen yjshen commented Dec 6, 2019

What is the purpose of the change

This PR implements Pulsar catalog which is part of FLIP-72.

The Pulsar catalog supports the following features by extending AbstractCatalog API:

  • Open and close the catalog
  • Database operations: list, get, exists, create, drop (create and drop should first check if the user has sufficient permissions)
  • Table operations: list, get, exist, create, drop (create and drop should first check if the user has sufficient permissions)

Brief change log

  • The main functionality of Catalog exists in PulsarCatalog and PulsarMetadataReader.
  • Pulsar Schema <-> Flink type conversion exists in SchemaUtils.

Verifying this change

This PR will be tested by unit tests and integration tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes) . Add Pulsar dependencies.
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 206bb09 (Fri Dec 06 06:58:15 UTC 2019)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 6, 2019

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@yjshen
Copy link
Member Author

yjshen commented Jan 17, 2020

@bowenli86 Hi Bowen, I've updated the PR with tests. Could you please help review it? Thanks!

@yjshen
Copy link
Member Author

yjshen commented Mar 27, 2020

@bowenli86 Hi Bowen, I've updated the PR with tests. Could you please help review it? Thanks!

@bowenli86
Copy link
Member

hi @yjshen sorry for the late response, I'm really busy right now and may have some time later April to take a detailed look. Can you try to find some other committers to help review?

@KurtYoung
Copy link
Contributor

Hi @yjshen , sorry for the late response on this. I think right now the community is busy with finishing 1.11 planned features thus don't have much capacity for reviewing this. I would raise this during 1.12 feature planning and hopefully we can get this and pulsar connectors in Flink 1.12.

@yjshen
Copy link
Member Author

yjshen commented Apr 21, 2020

Hi @bowenli86 @KurtYoung, thanks for the update. Looking forward to further discussions on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants