New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15298][docs] Fix dependences in the DataStream API Tutorial doc #10607
[FLINK-15298][docs] Fix dependences in the DataStream API Tutorial doc #10607
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f58a3ea (Fri Feb 28 21:47:22 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on the removal of flink-clients
. However, there is a problem with setting the other two to provided
:
With these dependencies set to provided
, you cannot run the example out of the box in (at least) IntelliJ anymore: you either need to enable the add-dependencies-for-IDEA
profile (not recommended) or tick Include dependencies with "Provided" scope
in the run configuration. We currently do not describe this anywhere.
Also, the command given for running the example ( mvn exec:java -Dexec.mainClass=wikiedits.WikipediaAnalysis
) does not work anymore. So maybe as a different approach, keep the default scope and instead mention this for the bonus exercise ("Running on a Cluster").
sorry for not re-reviewing it earlier - since 1.9 is a bit too old now, let me close this PR |
What is the purpose of the change
This pull request fixes the maven dependence issues in the DataStream API tutorial doc where:
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation