Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8][FLINK-12040][build] Remove unused akka dependencies #10802

Merged
merged 2 commits into from Jan 17, 2020

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Jan 8, 2020

Removes a few unused dependencies; mostly to get Apache Camle out of the dependency graph which shows up as vulnerable in security checks.

@zentol zentol changed the title [FLINK-12040][build] Remove unused akka dependencies [1.8][FLINK-12040][build] Remove unused akka dependencies Jan 8, 2020
@flinkbot
Copy link
Collaborator

flinkbot commented Jan 8, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 06bb6f5 (Wed Jan 08 15:47:43 UTC 2020)

Warnings:

  • 4 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 8, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. LGTM modulo the akka-camel entry in the parent pom.xml which I believe could be removed.

flink-yarn/pom.xml Show resolved Hide resolved
@zentol zentol merged commit 33641f6 into apache:release-1.8 Jan 17, 2020
@zentol zentol deleted the 12040 branch January 17, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants