Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15726] [Blink Planner] [hotfix] Fix error message in StreamExecTableSourceScan #10914

Closed
wants to merge 3 commits into from

Conversation

benoitparis
Copy link
Contributor

Applying the Blink version of:
02b676e#diff-ed386bd5b2f8bc873a24413ff1d82562

What is the purpose of the change

Correcting an error message.

Brief change log

  • Fixing a String

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

N/A

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no ****/ don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@benoitparis
Copy link
Contributor Author

Oops, copied from the wrong version, the inputDataType variable does not exists. Fixing it

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2ea76a0 (Tue Jan 21 11:18:34 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 21, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dawidwys
Copy link
Contributor

Hi @benoitparis thank you for your contribution.

Could you also fix it in BatchExecTableSourceScan?

@benoitparis
Copy link
Contributor Author

@dawidwys done!

@dawidwys dawidwys self-assigned this Jan 21, 2020
dawidwys pushed a commit to dawidwys/flink that referenced this pull request Jan 22, 2020
StreamExecTableSourceScan & BatchExecTableSourceScan

This closes apache#10914
dawidwys pushed a commit to dawidwys/flink that referenced this pull request Jan 22, 2020
StreamExecTableSourceScan & BatchExecTableSourceScan

This closes apache#10914
@dawidwys dawidwys closed this in 349492e Jan 22, 2020
dawidwys pushed a commit that referenced this pull request Jan 22, 2020
StreamExecTableSourceScan & BatchExecTableSourceScan

This closes #10914
JTaky pushed a commit to JTaky/flink that referenced this pull request Feb 20, 2020
StreamExecTableSourceScan & BatchExecTableSourceScan

This closes apache#10914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants