[FLINK-15768] [Client/Job Submission] Consolidate executor related cl…

[HuangZhenQiu]

What is the purpose of the change

Consolidate executor related classes into the same module that underneath of org.apache.flink.client.deployment.exectuors.

Brief change log

• Move classes into org.apache.flink.client.deployment.exectuors package.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1dcb22b (Fri Jan 24 23:38:01 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[HuangZhenQiu]

@kl0u
This change is to consolidate executor related classes in the same module. After this the cluster mode deployment classes within in org.apache.flink.client.deployment.deployers. How do you think?

[flinkbot]

CI report:

• 1dcb22b UNKNOWN
• d62dc06 Travis: FAILURE Azure: FAILURE
• 86df7f4 Travis: SUCCESS Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[kl0u]

Changes look good @HuangZhenQiu ! I will merge as soon as Travis gives green light!

[kl0u]

@HuangZhenQiu I was too fast to approve.. :(

Did you notice that Flink does not compile?
Please fix this and I will have another look.

[HuangZhenQiu]

@kl0u
It is a connection timeout in WebFrontendITCase. I will take a look.

[kl0u]

@HuangZhenQiu It does not seem to be a connection timeout. It seems like a compilation issue related to the changes of the PR https://travis-ci.com/flink-ci/flink/builds/146027147. Isn't this correct?

[HuangZhenQiu]

@kl0u
Yes, you are right. There is also a compile error in kubernates executor. I already pushed a fix.

[kl0u]

Merged