-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15646][K8s]Configurable K8s context support. #10956
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b8552e9 (Wed Jan 29 07:31:11 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@zhengcanbin The changes looks really good to me. I just have some minor comments.
@tisonkun could you take another look and help to merge? |
k8s is more shorthand and used commonly in an informal context, sounds reasonable for the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @zhengcanbin . I left some comments.
Beside, Azure fails on a known issue https://issues.apache.org/jira/browse/FLINK-15811. I'd suggest you rebase on nightly master and retest.
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubeClientFactory.java
Show resolved
Hide resolved
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubeClientFactory.java
Outdated
Show resolved
Hide resolved
...ernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
Outdated
Show resolved
Hide resolved
b8552e9
to
6d0b595
Compare
Thanks, @tisonkun ! Another commit was pushed to fix the comments. |
What is the purpose of the change
One would be forced to firstly use kubectl config use-context to switch to the desired context if working with multiple K8S clusters or having multiple K8S "users" for interacting with the specified cluster, so it is an important improvement to add an option(kubernetes.context) for configuring arbitrary contexts when deploying a Flink cluster. If that option is not specified, then the current context in the config file would be used.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation