Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-15646][K8s]Configurable K8s context support. #10956

Closed
wants to merge 2 commits into from

Conversation

zhengcanbin
Copy link
Contributor

What is the purpose of the change

One would be forced to firstly use kubectl config use-context to switch to the desired context if working with multiple K8S clusters or having multiple K8S "users" for interacting with the specified cluster, so it is an important improvement to add an option(kubernetes.context) for configuring arbitrary contexts when deploying a Flink cluster. If that option is not specified, then the current context in the config file would be used.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b8552e9 (Wed Jan 29 07:31:11 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 29, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zhengcanbin
Copy link
Contributor Author

cc @wangyang0918 @tisonkun

@wangyang0918
Copy link
Contributor

@zhengcanbin The changes looks really good to me. I just have some minor comments.

  1. The module in the commit title should be k8s or kubernetes. Maybe "[FLINK-15646][k8s] Make kubernetes context configurable" is better.
  2. Even the abbreviation k8s is reasonable in the commit title to leave more characters for other useful information. I suggest to avoid in the code, documentation. This is not forced, and you could leave it as you want.

@tisonkun could you take another look and help to merge?

@zhengcanbin
Copy link
Contributor Author

@zhengcanbin The changes looks really good to me. I just have some minor comments.

1. The module in the commit title should be `k8s` or `kubernetes`. Maybe "[FLINK-15646][k8s] Make kubernetes context configurable" is better.

2. Even the abbreviation `k8s` is reasonable in the commit title to leave more characters for other useful information. I suggest to avoid in the code, documentation. This is not forced, and you could leave it as you want.

k8s is more shorthand and used commonly in an informal context, sounds reasonable for the commit message.

@tisonkun tisonkun self-assigned this Feb 10, 2020
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @zhengcanbin . I left some comments.

Beside, Azure fails on a known issue https://issues.apache.org/jira/browse/FLINK-15811. I'd suggest you rebase on nightly master and retest.

@zhengcanbin zhengcanbin changed the title [FLINK-15646][client]Configurable K8s context support. [FLINK-15646][K8s]Configurable K8s context support. Feb 11, 2020
@zhengcanbin
Copy link
Contributor Author

Thanks for your contribution @zhengcanbin . I left some comments.

Beside, Azure fails on a known issue https://issues.apache.org/jira/browse/FLINK-15811. I'd suggest you rebase on nightly master and retest.

Thanks, @tisonkun ! Another commit was pushed to fix the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants