New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-15807][docs] Add Java 11 to supported JDKs #10974
Conversation
Version is already declared in root pom.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b197669 (Thu Jan 30 11:39:49 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, fair enough to say the Flink core could run with Java 11 smoothly now.
Meanwhile, if we're going to announce java 11 support in 1.10.0 release, hopefully somewhere we could remind our users that certain source/sink (cassandra/hbase/hive/old-version-kafka) don't support java 11 yet, to avoid possible misunderstanding. Maybe adding a release note for FLINK-10725 could do the work.
cc @GJL for notice.
I don't understand what we want to document in the release notes exactly. The description of the PR says that we do not fully understand why some connectors don't work. Can we try out all connectors on JDK11? I am against documenting things that we don't understand ourselves. (edited) |
We could document that we haven't tested these features on Java 11, since the backing library does not officially support Java 11. |
I am ok with saying that we haven't tested some connectors. Is there a list of untested connectors or should we just say all of them? |
What is listed in the PR description (Cassandra, Hive, HBase, Kafka 0.8-0.11). These are the features for which we have tests that are not being run on Java 11. We also have no e2e runs on YARN, but the IT cases are passing. |
I could see this already tracked by #10997 , so it seems the PR here is ready to go. |
Adds Java 11 to the set of supported JDKs.
Note that certain features (cassandra, hive, hbase, kafka 0.X) may not work on Java 11, but I don't know whether this is due to an incompatibility in our connector or the external server (the more likely). Hence I opted to not document this, on the assumption that users will run their stuff on a single Java version, and if they have Java 11 with a working cassandra server then the connector will likely work as well.