New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-13978][build system] Add experimental support for building on Azure Pipelines #10976
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 322bf18 (Thu Jan 30 15:17:40 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
CI report:
Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick skim, will do a more thorough review another time.
flink-end-to-end-tests/test-scripts/test_kubernetes_embedded_job.sh
Outdated
Show resolved
Hide resolved
Do we have to make any changes to CiBot? |
322bf18
to
0e9afb2
Compare
Not that I'm aware of. If we want to trigger e2e tests through CiBot, the variable "MODE=e2e" needs to be passed. But I can change that to whatever you like. |
0e9afb2
to
438cbcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second round
438cbcb
to
719e8c3
Compare
Thanks a lot for your review. Please let me know if you have further comments. |
e7f91ce
to
4f4267a
Compare
flink-end-to-end-tests/test-scripts/test_streaming_elasticsearch.sh
Outdated
Show resolved
Hide resolved
4f4267a
to
0d869f3
Compare
I believe I have reacted to all your comments. Please let me know if there's more feedback.
Maybe you actually need to do a minor change in there, as the name of the builds has changed. |
Good to know; it's just a simple configuration change that I can already apply. Will they be called like in the build you linked? ( |
You missed #10976 (comment) |
I have seen that, but that's not a reason. You're explaining what you are doing, not why. |
You weren't kidding when you said the tests are invasive :P |
Yes |
I have adjusted CiBot; if everything is setup correctly it should start linking azure builds in this PR for new commits. |
Awesome, thanks |
da5a1bf
to
af8c961
Compare
ae57643
to
7c444b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
What is the purpose of the change
This pull request adds support for building and testing Flink on Azure Pipelines.
There are two entry files (build definitions) in this pull request
a)
azure-pipelines.yml
for the use with free Azure Pipelines accounts (executes all tests with default parameters)b)
tools/azure-pipelines/build-apache-repo.yml
is a build definition specifically for theapache/flink
repo. It uses a custom build machines through theflink-ci/flink
repository. These machines have a lot of performance, thus providing faster build times.Both entry files rely on the same build job definitions in
tools/azure-pipelines/jobs-template.yml
.In addition to that, there are some utilities for running tests on Azure added in this PR. Travis test execution should be unaffected by this change.
Verifying this change
Note: e2e test execution does currently fail, due to an issue with minikube.
Does this pull request potentially affect one of the following parts:
Documentation
(work in progress) documentation is available here: https://cwiki.apache.org/confluence/display/FLINK/%5Bpreview%5D+Azure+Pipelines