[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1

[tillrohrmann]

What is the purpose of the change

Upgrade jackson-databind dependency to 2.10.1

cc @wangyang0918

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d49b533 (Mon Feb 03 14:06:25 UTC 2020)

Warnings:

• 1 pom.xml files were touched: Check for build and licensing issues.
• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• d49b533 Travis: SUCCESS Azure: FAILURE

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[zentol]

Seems unrelated (good idea though).

[wangyang0918]

@tillrohrmann Thanks for creating this PR.

The current version(4.5.2) of kubernetes-client has fixed problem about different version conflict of dependency com.fasterxml.jackson. So of cause, we could remove the exclude part and using transitive dependencies.

Then if we remove the explicit dependencies and exclusions, i think we do not need to shade the com.fasterxml.jackson related packages anymore.

[tillrohrmann]

Good point @wangyang0918. I'll remove the relocations then.

[tillrohrmann]

Well, actually I would like to leave it like this because at the moment we don't have a unrelocated jackson dependency in flink-dist. I think it should be a follow-up issue to unify the differently relocated Jackson dependencies and to have a single version in Flink.

[wangyang0918]

@tillrohrmann I have checked the flink-dist_2.11-1.11-SNAPSHOT.jar. It seems that we have already bundled the unrelocated jackson.

wangyang-pc:build-target danrtsey.wy$ unzip -l lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep 'com/fasterxml/jackson' | grep -v 'shaded' | wc -l
908

[tillrohrmann]

I think you are mistakingly counting relocated Jackson dependencies. If you run jar tf flink-dist_2.11-1.11-SNAPSHOT.jar| grep ^com/fasterxml/jackson | wc -l then you will get 0.

[tillrohrmann]

Merging this PR now.

[wangyang0918]

@tillrohrmann I think the two commands have no differences.
I build the master branch and still could find the unrelocated jackson classes. Do i miss something?

$ jar tf lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep ^com/fasterxml/jackson | wc -l
     908

$ jar tf lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep ^com/fasterxml/jackson | head -n 10
com/fasterxml/jackson/
com/fasterxml/jackson/databind/
com/fasterxml/jackson/databind/AbstractTypeResolver.class
com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty.class
com/fasterxml/jackson/databind/AnnotationIntrospector.class
com/fasterxml/jackson/databind/BeanDescription.class
com/fasterxml/jackson/databind/BeanProperty$Bogus.class
com/fasterxml/jackson/databind/BeanProperty$Std.class
com/fasterxml/jackson/databind/BeanProperty.class

[tillrohrmann]

Hmm this is strange. Which version of maven did you use for building Flink @wangyang0918? I think it should be <= 3.2.5 otherwise shading might not properly work. I checked also the RC1 and I couldn't find unrelocated Jackson dependencies in it.

[wangyang0918]

@tillrohrmann You are right. The maven version >3.2.5 could not shade the jackson properly. Let's unify the different relocated jackson dependencies in the future.